Refactor device code around capabilities [NFC] #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. to no longer take a ProgramFeatures argument, since that information can be deduced from the supplied device.
.. to no longer take a stopping condition argument, since that information can be obtained from the supplied capabilities. Also eliminate the max_expension argument since PL is moving away from it.
.. to not take backend and capability arguments, since those can be computed from the supplied device.
.. instead of legacy-device-style op strings.
.. and remove obsolete device properties.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1149 +/- ##
==========================================
- Coverage 97.88% 97.87% -0.02%
==========================================
Files 76 76
Lines 10863 10847 -16
Branches 1283 1282 -1
==========================================
- Hits 10633 10616 -17
Misses 179 179
- Partials 51 52 +1 ☔ View full report in Codecov by Sentry. |
rauletorresc
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies device related code around capability checks and decomposition, and eliminates the use of
"Adjoint(*)"and"C(*)"declarations in favour of DeviceCapabilities and OperationProperties dataclasses.Includes the following (non-functional) changes:
get_device_capabilitysignaturecatalyst_decomposesignatureQJITDevice.__init__signaturepennylane_operation_setand useDeviceCapabilitiesinsteadoperations,observables, andmeasurement_processesproperties from our device classesSome of the code seems to have been written solely to facilitate testing, which should be avoided.
[sc-67124]