-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catalyst works with numpy 2.0 #1119
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1119 +/- ##
=======================================
Coverage 97.88% 97.88%
=======================================
Files 75 75
Lines 10749 10749
Branches 1259 1259
=======================================
Hits 10522 10522
Misses 179 179
Partials 48 48 ☔ View full report in Codecov by Sentry. |
892544f
to
fdf1a4e
Compare
fdf1a4e
to
9a8c479
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still labeled do-not-merge
? I'll leave it up to you to decide when to merge.
Sorry, forgot to remove the tag. I think it should be good for merging. |
Should wheels be built to check against the numpy upgrade? |
@erick-xanadu, I just pushed a last change, which is to add scipy==1.13 to requirements. I think it is necessary since we have numpy==2.0. |
Added the label |
Context:
After Pennylane support numpy 2.0, catalyst needs to add this support.
Description of the Change:
Benefits:
Adds support for numpy 2.0
Related GitHub Issues:
[sc-61401]