Skip to content

[Snyk] Upgrade @vscode/webview-ui-toolkit from 1.2.2 to 1.4.0 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sumansaurabh
Copy link

@sumansaurabh sumansaurabh commented Mar 18, 2025

User description

snyk-top-banner

Snyk has created this PR to upgrade @vscode/webview-ui-toolkit from 1.2.2 to 1.4.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 3 versions ahead of your current version.

  • The recommended version was released a year ago.

Release notes
Package name: @vscode/webview-ui-toolkit
  • 1.4.0 - 2023-12-06

    Features

    • update dropdown styles: updates some dropdown styles to match new VS Code dropdown style (#532), closes #521

    Docs

    • fix image typo: fixes incorrect image used in badge docs (#522)

    Admin

    • bump @ microsoft/fast-element: bumps @ microsoft/fast-element from 1.6.2 to 1.12.0 (#525)
    • bump @ microsoft/fast-foundation: bumps @ microsoft/fast-foundation from 2.38.0 to 2.49.4 (#525), closes #494
    • bump @ microsoft/fast-react-wrapper: bumps @ microsoft/fast-react-wrapper from 0.1.18 to 0.3.22 (#525)
    • bump eslint related deps: bumps eslint and other related packages to latest stable versions (#526)
    • update ci pipelines: updates github and azure ci pipelines to use node v18 (#526)
    • bump prettier: bumps prettier from 2.2.1 to 3.1.0 (#528)
    • bump @ microsoft/api-extractor: bumps @ microsoft/api-extractor from 7.18.9 to 7.38.4 (#529)
    • add tsdoc.json: adds a tsdoc.json file to resolve api-extrator warnings (#529)
    • bump typescript: bumps typescript from 4.3.5 to 4.6.2 (#530), closes #514
    • add tslib production dep: fixes error in other package managers (i.e. yarn) where tslib could not be resolved (#531), closes #451
  • 1.3.1 - 2023-11-14

    Admin

    • update npmignore: adds a directory to npmignore (accidentally published a big test folder in v1.3.0, sorry 😅)
  • 1.3.0 - 2023-11-13

    Features

    • input border radius: adds a 2px border radius to input elements (text field and text area) to match new VS Code button style (#510)

    Docs

    • replace storybook with codesandbox: removes storybook and replace it with codesandbox sample links (#460), closes #446
    • dropdown label: adds better docs on how to create labels in dropdown that adhere to VS Code design language (#463), closes #461
    • divider and radio group typos: fixes two typos found in the documentation (#462)
    • getting started: updates esbuild configuration code snippet in getting started guide (#450)
    • data grid typo: fixes data grid example code typo (#471)
    • contributing docs: removes deleted npm test and build:docs scripts from contributing doc (#492)
    • editable data grid: adds a new section to the data grid docs linking to the editable data grid sample extension (#499), closes #493
    • radio docs: adds note about workaround fix to the issue described in #476 (#511)

    Admin

    • remove jest dependency: removes unused jest dependency (#459)
    • react testing environment: adds npm script and testing environment to test toolkit react components (#478)
    • bump word-wrap: bumps word-wrap from 1.2.3 to 1.2.4 (#501)
    • bump @ babel/traverse: bumps @ babel/traverse from 7.15.4 to 7.23.2 (#515)
    • bump http-cache-semantics: bumps http-cache-semantics from 4.1.0 to 4.1.1 (#454)
    • bump json5: bumps json5 from 1.0.1 to 1.0.2 (#443)
  • 1.2.2 - 2023-02-24

    Bug fixes

    • fix react build script: fixes react build script that was generating incorrect react type declaration file (#456), closes #455

    Docs

    • new getting started guide: adds new content to getting started guide demoing better component API usage and extension CSP (#383), closes #74 and #348
    • update resource links: adds and removes a few links to resources in the project readme.md and getting-started.md (#447)
    • remove readme badge: removes deploy docs readme badge since it was broken to due removal of docs CD pipeline (#449)
    • data grid docs: updates data grid docs to show how to create data grids with React (#457), closes #453

    Admin

    • add .eslintrc.cjs to npmignore: forgot to include in a previous release (#444), resolves #438
    • enable codeql: adds codeql to azure pipeline for improved static analysis and security audits of toolkit source code (#441)
from @vscode/webview-ui-toolkit GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:


Description

  • Upgraded @vscode/webview-ui-toolkit from version 1.2.2 to 1.4.0 to enhance functionality and security.
  • Updated the vscode engine requirement to ensure compatibility with newer versions.
  • Several related dependencies were also updated to their latest versions.

Changes walkthrough 📝

Relevant files
Dependencies
package-lock.json
Upgrade @vscode/webview-ui-toolkit and dependencies           

default/weather-webview/package-lock.json

  • Upgraded @vscode/webview-ui-toolkit from version 1.2.2 to 1.4.0.
  • Updated vscode engine requirement from ^1.74.0 to ^1.75.0.
  • Updated several dependencies including @microsoft/fast-element,
    @microsoft/fast-foundation, and @microsoft/fast-react-wrapper.
  • Added a new dependency tslib version 2.8.1.
  • +71/-86 
    package.json
    Update @vscode/webview-ui-toolkit dependency                         

    default/weather-webview/package.json

  • Updated @vscode/webview-ui-toolkit dependency from ^1.2.2 to ^1.4.0.
  • +1/-1     

    💡 Penify usage:
    Comment /help on the PR to get a list of all available Penify tools and their descriptions

    Snyk has created this PR to upgrade @vscode/webview-ui-toolkit from 1.2.2 to 1.4.0.
    
    See this package in npm:
    @vscode/webview-ui-toolkit
    
    See this project in Snyk:
    https://app.snyk.io/org/sumansaurabh/project/d013ed84-8285-4118-a30a-fa4c3788afb5?utm_source=github&utm_medium=referral&page=upgrade-pr
    @penify-dev penify-dev bot added enhancement New feature or request Review effort [1-5]: 2 labels Mar 18, 2025
    Copy link

    penify-dev bot commented Mar 18, 2025

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    2, because the changes are primarily version upgrades in the package-lock.json and package.json files, which are straightforward to review.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    Deprecated Package: The upgraded version of @vscode/webview-ui-toolkit (1.4.0) is marked as deprecated. This could lead to potential issues in the future if no alternative is provided.

    🔒 Security concerns

    No

    Copy link

    penify-dev bot commented Mar 18, 2025

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Maintainability
    Lock the dependency version to prevent unexpected future upgrades

    Consider locking the version to a specific release instead of using a caret (^) to avoid
    unexpected upgrades in the future.

    default/weather-webview/package.json [43]

    -"@vscode/webview-ui-toolkit": "^1.4.0",
    +"@vscode/webview-ui-toolkit": "1.4.0", // Lock to specific version
     
    Suggestion importance[1-10]: 8

    Why: Locking the version can prevent unexpected issues from future upgrades, making this a valuable suggestion that directly impacts maintainability.

    8
    Security
    Review the changelog for potential security vulnerabilities in the new version

    Ensure that the new version does not introduce any security vulnerabilities by reviewing
    the changelog or release notes.

    default/weather-webview/package.json [43]

    -"@vscode/webview-ui-toolkit": "^1.4.0",
    +"@vscode/webview-ui-toolkit": "^1.4.0", // Review changelog for security issues
     
    Suggestion importance[1-10]: 7

    Why: This suggestion addresses a critical aspect of software maintenance—security. However, it does not suggest a specific code change, which reduces its score slightly.

    7
    Compatibility
    Verify compatibility of the upgraded dependency version with existing code

    Consider verifying the compatibility of the new version with existing code to avoid
    potential breaking changes.

    default/weather-webview/package.json [43]

    -"@vscode/webview-ui-toolkit": "^1.4.0",
    +"@vscode/webview-ui-toolkit": "^1.4.0", // Ensure compatibility
     
    Suggestion importance[1-10]: 6

    Why: While it's important to verify compatibility, the suggestion does not provide a concrete action or change to the code itself, making it less impactful.

    6
    Testing
    Run tests post-upgrade to confirm functionality remains intact

    It may be beneficial to run tests after upgrading the dependency to ensure that no
    functionality is broken.

    default/weather-webview/package.json [43]

    -"@vscode/webview-ui-toolkit": "^1.4.0",
    +"@vscode/webview-ui-toolkit": "^1.4.0", // Run tests after upgrade
     
    Suggestion importance[1-10]: 6

    Why: Running tests is a good practice after an upgrade, but the suggestion lacks a direct code change, which limits its effectiveness.

    6

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants