This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PRIV] WIP - Wire up Private Transaction Processor #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macfarla
suggested changes
Feb 8, 2019
| LOG.info("Got the response as ", receiveResponse.getPayload()); | ||
|
|
||
| WorldUpdater privateWorldState = messageFrame.getPrivateWorldState(DEFAULT_PRIVACY_GROUP_ID); | ||
| // TransactionProcessor.Result result = |
...reum/core/src/main/java/tech/pegasys/pantheon/ethereum/privacy/PrivateMutableWorldState.java
Outdated
Show resolved
Hide resolved
...m/core/src/main/java/tech/pegasys/pantheon/ethereum/privacy/PrivateTransactionProcessor.java
Outdated
Show resolved
Hide resolved
Puneetha17
force-pushed
the
wireup-privacy
branch
from
8f8fa2c to
f661049
Compare
Puneetha17
force-pushed
the
wireup-privacy
branch
from
e6f7944 to
a57e6f6
Compare
macfarla
approved these changes
Feb 10, 2019
| @@ -225,6 +236,7 @@ | |||
| checkNotNull(precompileContractRegistryBuilder, "Missing precompile contract registry"); | |||
| checkNotNull(messageCallProcessorBuilder, "Missing message call processor"); | |||
| checkNotNull(transactionProcessorBuilder, "Missing transaction processor"); | |||
| checkNotNull(privateTransactionProcessorBuilder, "Missing transaction processor"); | |||
There was a problem hiding this comment.
might be clearer to say "Missing private transaction processor"
|
this PR is marked as WIP - should not have been merged we were developing a POC of how this may work in Pantheon |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add Message Frame to Pre compiled contracts