This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
EthScheduler additions #767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the services thread pool and a computation thread pool to the EthScheduler. * Services are long running, sequential, and infrequently start tasks such as Full Sync and Fast Sync. * Computations are short and high CPU intensity tasks such as ECDSA signature extractions and POW validation. The intent is that each runnable represents one such extraction and the extractions from a block are saturated across available processing power. These computations should have zero dependencies outside their object and thread.
ajsutton
approved these changes
Feb 5, 2019
| "{} computation executor did not shutdown cleanly.", this.getClass().getSimpleName()); | ||
| computationExecutor.shutdownNow(); | ||
| computationExecutor.awaitTermination(2L, TimeUnit.MINUTES); | ||
| } |
There was a problem hiding this comment.
This is starting to add up to a lot of waiting. Maybe we should set it up so that we call shutdown on all of them, wait then shutdownNow on any not shutdown, then wait and log any that still failed to shutdown?
There was a problem hiding this comment.
sounds like a good first issue - https://github.com/PegaSysEng/pantheon/issues/768
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add the services thread pool and a computation thread pool to the
EthScheduler.
such as Full Sync and Fast Sync.
signature extractions and POW validation. The intent is that each
runnable represents one such extraction and the extractions from a
block are saturated across available processing power. These
computations should have zero dependencies outside their object and
thread.