Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Build stability #715

Merged
merged 2 commits into from
Jan 30, 2019
Merged

Build stability #715

merged 2 commits into from
Jan 30, 2019

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Jan 30, 2019

PR description

  • make spotless groovy formatter ignore compilation errors
  • move errorprone FieldCanBeFinal to off for performance reasons.

@shemnon
Build stability
f64aad3 
* make spotless groovy formatter ignore compilation errors
* move errorprone FieldCanBeFinal to off for performance reasons.
ajsutton
ajsutton approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sad to lose FieldCanBeFinal but it's not only inefficient it prevents us from using String parameters with PicoCLI.

@shemnon shemnon merged commit e79eaa4 into PegaSysEng:master Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shemnon @ajsutton