This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Metrics Prometheus Push Gateway Support #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes metrics are hard to poll (docker containers with varying ip addresses). Because of that the push gateway exists. This extends the metrics system to support push or pull mode for metrics (but not both at the same time).
Sometimes metrics are hard to poll (docker containers with varying ip addresses). Because of that the push gateway exists. This extends the metrics system to support push or pull mode for metrics (but not both at the same time).
shemnon
added
the
doc next release
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Sometimes metrics are hard to poll (docker containers with varying ip
addresses). Because of that the push gateway exists. This extends the
metrics system to support push or pull mode for metrics (but not both
at the same time).
Three new flags
--metrics-mode=<push|pull> - Whether we are in pull mode (the default) whereprometheus is expected to poll or push mode where pantheon pushes to
a push gateway.
--metrics-push-interval=<integer> the frequency, in seconds, between pushes tothe push gateway. Only relevant in push mode
--metrics-prometheus-job=<string> The name of the job to report in the push gatewayAlso,
--metrics-host=and--metrics-port=gain new meaning in push mode. Instead of theserver they are opening up it is the host and the port of the push gateway it should push to.