[PRIV] Prepare private transaction support #538
Conversation
|
|
iikirilov
changed the title
antonydenyer
force-pushed
the
orion
branch
2 times, most recently
from
75cb854 to
c9614c6
Compare
antonydenyer
force-pushed
the
orion
branch
2 times, most recently
from
da60b01 to
c57080e
Compare
antonydenyer
force-pushed
the
orion
branch
2 times, most recently
from
ed337c7 to
f5b76ca
Compare
Yes but no! Until Consensys/orion#197 is fixed we need some kind of binary. When that's done we can switch over to using the snapshot. The alternative is we ignore Orion integration and acceptance tests on CI and force developers to be running Orion locally. |
If all you need is an Orion binary with the latest changes, you can get it here! https://bintray.com/consensys/binaries/orion/0.1.0-SNAPSHOT |
|
For today I am ok with the idea of us having the libs included. As soon as Orion ships with a pom file, it will be possible to delete these libs. Until we do that, we need to support the approach of including the files directly, in order to unblock the work in this area of the codebase. |
rojotek
dismissed
macfarla’s stale review
changes requested are either done, or scheduled for the future once supporting work is done.
antonydenyer
force-pushed
the
orion
branch
5 times, most recently
from
e78b8c6 to
2619bf7
Compare
- Start orion on random port - test payloads can be send and received
commit 646fc06 Author: Antony Denyer <git@antonydenyer.co.uk> Date: Tue Jan 22 07:30:15 2019 +0000 Use snapshot build of orion commit c63a1bd Author: Antony Denyer <git@antonydenyer.co.uk> Date: Mon Jan 21 14:57:37 2019 +0000 update build image commit bb98293 Author: Antony Denyer <git@antonydenyer.co.uk> Date: Mon Jan 14 16:51:01 2019 +0000 Use ephemeral instance of Orion for integration test - Start orion on random port - test payloads can be send and received commit 9c9dd38 Author: Puneetha <puneetha17@gmail.com> Date: Fri Jan 11 10:52:46 2019 +0000 Add integration tests commit 2441d30 Author: Puneetha <puneetha17@gmail.com> Date: Fri Jan 11 10:50:05 2019 +0000 Add Orion module
PR description
Adds an Orion client with integration tests.
The purpose of this PR is to prepare for supporting private transaction in Pantheon. To support private transaction it is required to access an enclave from Pantheon. As Orion is an enclave created by the same organisation that maintains Pantheon it seems natural to support the Orion enclave first.
No functionality is added to Pantheon in this PR.