This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Revert "Repair Clique Proposer Selection" #339 - Breaks Görli testnet #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b8dbfd5.
smatthewenglish
approved these changes
Nov 30, 2018
|
(a) it reverts too much (I just wanted the one change undone) and So I am abandoning this one in favor of #343 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #339
Görli's testnet regularly has proposers miss their turn and their genesis block actually had a bad validator specified (that was voted out as soon as they could) So many blocks do not have the proper "proposer" as their block generator. As a consequence the CliqueDifficultyValidationRule fails regularly, in fact it fails at block 3, so this should be easy to re-create locally.