This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nc 1145 Acceptance test for getTransactionReceipt JSON-RPC method #278
Nc 1145 Acceptance test for getTransactionReceipt JSON-RPC method #278
Changes from 8 commits
1ff064a
2146a6a
ef0db70
85d70a3
7c46e78
984dd7d
5f9135b
a3ec974
4549355
8f1193d
90ffc61
e404973
4929caf
1a581a4
41c6026
b4c1054
e07ef34
01f3339
d0653fc
42beaf4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't doing any sanity checking - just checking it's present so probably should just be
ExpectEthGetTransactionReceiptPresent
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
param
should have a meaningful name - maybetransactionHash
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming-wise this would probably be better as:
minerNode.verify(eth.transactionReceiptIsAvailable(transactionHash))
You shouldn't need to call
toString()
in the test - the DSL should accept the actual Hash and convert to a string itself if needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed and moved toString() into DSL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably would be better as
minerNode.verify(eth.transactionReceiptNotAvailable("..."))
. Using a string here is probably sensible since the test is simpler that way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed test to be more succinct