Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PIE-1805] Add test cases for trace_replayBlockTransactions #1881

Merged
merged 6 commits into from
Aug 26, 2019

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Aug 23, 2019

PR description

Update chain data and add test cases for trace_replayBlockTransactions tests. Also:

  • Update BlockchainSetupUtil with a constructor that accepts arbitrary genesis and block data files
  • Update tests to be agnostic as to JSON-RPC response key ordering

@mbaxter mbaxter marked this pull request as ready for review August 23, 2019 20:02
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@@ -90,4 +96,9 @@ private JsonNode formatTrace(
ObjectMapper mapper = new ObjectMapper();
return mapper.createObjectNode();
}

private Object emptyResult() {
ObjectMapper mapper = new ObjectMapper();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: final

@AbdelStark AbdelStark merged commit cb80e33 into PegaSysEng:master Aug 26, 2019
pscott pushed a commit to pscott/pantheon that referenced this pull request Sep 2, 2019
…ng#1881)

* Add chain data resources

* Update tests for tracing to run on custom data, add test cases

* Regenerate test cases, update tests to be agnostic on key ordering

* Remove dead code

* Move to-be-implemented test cases to root trace directory
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants