Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PIE-1791] Fix logic to disconnect from peers on fork #1863

Merged
merged 5 commits into from
Aug 19, 2019
Merged

[PIE-1791] Fix logic to disconnect from peers on fork #1863

merged 5 commits into from
Aug 19, 2019

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Aug 16, 2019

PR description

Fix logic that handles invalid blocks. On an InvalidBlockException, we should always disconnect the sync target.

Also:

  • Make logs more verbose for easier debugging
  • Log a warning if an invalid block is discovered
  • Add test utilities for working with chain forks

@mbaxter mbaxter marked this pull request as ready for review August 16, 2019 23:09
@mbaxter mbaxter merged commit ffafbc3 into PegaSysEng:master Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shemnon shemnon shemnon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbaxter @shemnon