Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

RevertReason changed to BytesValue #1746

Merged
merged 37 commits into from
Jul 30, 2019
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
639b410
RevertReason changed to BytesValue
Jul 24, 2019
8bd82ae
post review
Jul 25, 2019
20f4316
Added static nodes acceptance test (#1745)
lucassaldanha Jul 24, 2019
a85980a
update vertx to 2.8.0 (#1748)
Jul 24, 2019
5b78518
Reduce number of builds retained for master (#1751)
ajsutton Jul 24, 2019
5c67f04
PIE-1792: Added chainId validation to PrivateTransactionValidator (#1…
lucassaldanha Jul 24, 2019
2f9818a
Added note about private transaction nonce (#1740)
MadelineMurray Jul 25, 2019
c3bf607
[PAN-2950] Use java.time.Clock instead of System.currentTimeMillis() …
Jul 25, 2019
09fb64c
Report node local address as the coinbase in Clique and IBFT. (#1758)
ajsutton Jul 25, 2019
fbb8736
Renamed HA section to make clearer what it is (#1750)
MadelineMurray Jul 25, 2019
e88de17
[PAN-2845] Added eea_getPrivateTransaction (#1729)
MadelineMurray Jul 25, 2019
8e6364d
Fixes PIE-1669 typo (#1763)
sgregglives Jul 25, 2019
6c07566
[PAN-2943] Renames various eea methods to priv methods, with associat…
josh-richardson Jul 25, 2019
ec7cfa0
[PAN-2727] Permissioning Acceptance Test - Verify OnChain Nodes Out o…
usmansaleem Jul 26, 2019
825242a
PAN-2723: Testing permissioning with static nodes behaviour (#1764)
lucassaldanha Jul 26, 2019
e38bec0
trying to fix stuff
Jul 26, 2019
a118716
Fixed RevertReasonAT
Jul 26, 2019
66d2b2d
Cleanup
Jul 26, 2019
d7af3d4
not sure what this one is about
Jul 26, 2019
ae80d96
repair empty revert reason
Jul 26, 2019
6bf9ff5
fixes PAN-2958 list typo (missing new line) (#1742)
NicolasMassart Jul 26, 2019
35278e7
Revert "[PAN-2950] Use java.time.Clock instead of System.currentTimeM…
Jul 26, 2019
168dcf4
[PAN-2444] Add CLI flag for setting WorldStateDownloader task cache …
Jul 26, 2019
b439d7f
Moved priv methods into priv section (#1770)
MadelineMurray Jul 27, 2019
7082eb4
[PAN-2881] [PAN-2885] Updated onchain permissioning to include accoun…
MadelineMurray Jul 27, 2019
c5f6a0a
Added privacy group methods for web3.js-eea (#1761)
MadelineMurray Jul 27, 2019
89a39a2
[PAN-2957] Add Java 11+ as a prerequisite for installing Pantheon usi…
bgravenorst Jul 27, 2019
6412d95
Updated revert reason example (#1754)
MadelineMurray Jul 27, 2019
5f4b5be
Typo doc in word "exceptoinal" (#1767)
helderjnpinto Jul 29, 2019
4c7b677
Added content on deploying for production (#1774)
MadelineMurray Jul 29, 2019
8e9bd85
Repaired empty revert reason output
Jul 29, 2019
4ed31e8
Merge remote-tracking branch 'upstream/master' into revert
Jul 29, 2019
ec7b1bf
Transaction receipt inserts 0x for empty revert reason
Jul 29, 2019
58b75cc
Merge remote-tracking branch 'upstream/master' into revert
Jul 29, 2019
e64e574
Repair failing AT
Jul 29, 2019
98fe982
Merge branch 'master' into revert
rain-on Jul 30, 2019
0ae3d4c
Merge branch 'master' into revert
rain-on Jul 30, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Repair failing AT
  • Loading branch information
tmohay committed Jul 29, 2019
commit e64e574636278e570f7aa00a3b52a10cc9d3f18f
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public void verify(final Node node) {
private boolean revertReasonIsEmpty(final Node node) {
return node.execute(transaction)
.map(TransactionReceiptWithRevertReason::getRevertReason)
.filter(String::isEmpty)
.filter(str -> str.equals("0x"))
.isPresent();
}
}