This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Capture all logs and errors in the Pantheon log output #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that log to slf4j have their logs output to Pantheon's logs properly.
… in the Pantheon logs.
ajsutton
changed the title
CjHare
approved these changes
May 13, 2019
|
There was a pass done to use |
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 14, 2019
* Add slf4j to log4j bindings as a runtime dependency so any libraries that log to slf4j have their logs output to Pantheon's logs properly. * Set a default exception handler to ensure uncaught exceptions wind up in the Pantheon logs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Pantheon uses some libraries that log to SLF4j but we didn't include a binding from SLF4j to Log4J at runtime so those logs were silently dropped. Include the binding so the libraries log correctly and we don't get an annoying warning about missing the binding at startup.
Additionally, set a default exception handler at the start of our main method so any uncaught exceptions are output to our logging rather than printed to system error which may get missed if a simple redirect is used.