Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

[PAN-1062] Specify pending transaction retention period (2 of 2) #1333

Merged
merged 26 commits into from
Apr 30, 2019
+130 −69
Merged

[PAN-1062] Specify pending transaction retention period (2 of 2) #1333

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ebc437d
pendingTransactionRetentionPeriod
smatthewenglish Apr 25, 2019
c5712d0
PENDING_TX_RETENTION_PERIOD
smatthewenglish Apr 25, 2019
3f7ffc4
test
smatthewenglish Apr 25, 2019
f7a9c9f
CommandTestAbstract
smatthewenglish Apr 25, 2019
abbcabd
13
smatthewenglish Apr 25, 2019
7727ab4
x
smatthewenglish Apr 25, 2019
45c1faf
x
smatthewenglish Apr 25, 2019
3866b1b
toml
smatthewenglish Apr 25, 2019
06bce30
x
smatthewenglish Apr 26, 2019
e17dcaf
0
smatthewenglish Apr 26, 2019
f42344d
PENDING_TX_RETENTION_HOURS
smatthewenglish Apr 26, 2019
b86c8c6
knst
smatthewenglish Apr 26, 2019
b94a4f4
kn
smatthewenglish Apr 26, 2019
559fea5
x
smatthewenglish Apr 26, 2019
feb92a2
~
smatthewenglish Apr 26, 2019
5f67f24
*
smatthewenglish Apr 26, 2019
11a9274
int
smatthewenglish Apr 26, 2019
2d9a7d6
pendingTransactionRetentionPeriod
smatthewenglish Apr 29, 2019
a5967e7
ChronoUnit.HOURS
smatthewenglish Apr 29, 2019
7734e0d
x
smatthewenglish Apr 29, 2019
d6b0e53
DEFAULT_TX_RETENTION_HOURS >< 2
smatthewenglish Apr 29, 2019
b460f19
debugging
smatthewenglish Apr 29, 2019
c64c680
clock.step(2L, ChronoUnit.HOURS)
smatthewenglish Apr 30, 2019
b888bf4
update
smatthewenglish Apr 30, 2019
97482fb
update update
smatthewenglish Apr 30, 2019
1d3eb99
x
smatthewenglish Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
x
  • Loading branch information
@smatthewenglish
smatthewenglish committed Apr 30, 2019
commit 559fea55f31d8f1481254f76529f4755e373368b
2 changes: 1 addition & 1 deletion pantheon/src/main/java/tech/pegasys/pantheon/cli/DefaultCommandValues.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public interface DefaultCommandValues {
String PANTHEON_HOME_PROPERTY_NAME = "pantheon.home";
String DEFAULT_DATA_DIR_PATH = "./build/data";
String MANDATORY_INTEGER_FORMAT_HELP = "<INTEGER>";
String PENDING_TX_RETENTION_PERIOD_FORMAT_HELP = "<INTEGER>h<INTEGER>m<INTEGER>s";
String DURATION_HELP = "<INTEGER>h<INTEGER>m<INTEGER>s";
String MANDATORY_MODE_FORMAT_HELP = "<MODE>";
String MANDATORY_NETWORK_FORMAT_HELP = "<NETWORK>";
String MANDATORY_NODE_ID_FORMAT_HELP = "<NODEID>";
Expand Down
4 changes: 2 additions & 2 deletions pantheon/src/main/java/tech/pegasys/pantheon/cli/PantheonCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,9 +485,9 @@ void setBootnodes(final List<String> values) {

@Option(
names = {"--tx-pool-retention-period"},
paramLabel = PENDING_TX_RETENTION_PERIOD_FORMAT_HELP,
paramLabel = DURATION_HELP,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
paramLabel = DURATION_HELP,
paramLabel = MANDATORY_INTEGER_FORMAT_HELP,

description =
"Maximum retention period of pending transactions in the transaction pool (default: ${DEFAULT-VALUE})",
"Maximum retention period of pending transactions, expressed in hours. Represented by primitive type 'long'. (default: ${DEFAULT-VALUE})",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: drop the redundant word 'expressed' and user's don't care how we represent the value internally.

Suggested change
"Maximum retention period of pending transactions, expressed in hours. Represented by primitive type 'long'. (default: ${DEFAULT-VALUE})",
"Maximum retention period of pending transactions in hours (default: ${DEFAULT-VALUE})",

arity = "1")
private final Integer pendingTxRetentionPeriod = PendingTransactions.PENDING_TX_RETENTION_HOURS;

Expand Down