This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Make contract size limit configurable. #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
approved these changes
Apr 6, 2019
| @@ -59,7 +60,8 @@ | |||
|
|
|||
| private MainnetProtocolSpecs() {} | |||
|
|
|||
| public static ProtocolSpecBuilder<Void> frontierDefinition() { | |||
| public static ProtocolSpecBuilder<Void> frontierDefinition(final OptionalInt contractSizeLimit) { | |||
| int frontierContractSizeLimit = contractSizeLimit.orElse(FRONTIER_CONTRACT_SIZE_LIMIT); | |||
There was a problem hiding this comment.
This probably should just be called contractSizeLimit since it's not necessarily the frontier limit anymore (similarly for the other cases).
…ng it possible to override milestone based configurations in a private network.
rojotek
force-pushed
the
make-contract-size-limit-configurable
branch
from
a3fc66c to
899bead
Compare
jframe
reviewed
Apr 7, 2019
| protocolSchedule, OptionalLong.of(0), MainnetProtocolSpecs.frontierDefinition()); | ||
| protocolSchedule, | ||
| OptionalLong.of(0), | ||
| MainnetProtocolSpecs.frontierDefinition(config.getContractSizeLimit())); |
There was a problem hiding this comment.
nit: perhaps extract config.getContractSizeLimit() to a local var to make the code little more readable. It's used quite a few times in this function.
| public static ProtocolSpecBuilder<Void> frontierDefinition() { | ||
| public static ProtocolSpecBuilder<Void> frontierDefinition( | ||
| final OptionalInt configContractSizeLimit) { | ||
| int contractSizeLimit = configContractSizeLimit.orElse(FRONTIER_CONTRACT_SIZE_LIMIT); |
There was a problem hiding this comment.
nit: make contractSizeLimit final
| return frontierDefinition() | ||
| public static ProtocolSpecBuilder<Void> homesteadDefinition( | ||
| final OptionalInt configContractSizeLimit) { | ||
| int contractSizeLimit = configContractSizeLimit.orElse(FRONTIER_CONTRACT_SIZE_LIMIT); |
There was a problem hiding this comment.
nit: make contractSizeLimit final
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
Apr 24, 2019
* Make the contract size limit configurable in the genesis config, making it possible to override milestone based configurations in a private network.
notlesh
pushed a commit
to notlesh/pantheon
that referenced
this pull request
May 4, 2019
* Make the contract size limit configurable in the genesis config, making it possible to override milestone based configurations in a private network.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the contract size limit configurable in the genesis config, making it possible to override milestone based configurations in a private network.