This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2347] nodepermissioningcontroller used for devp2p connection filtering #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassaldanha
approved these changes
Mar 19, 2019
| @@ -65,8 +65,7 @@ public void startPeerDiscoveryCallback(final Runnable peerDiscoveryCallback) { | |||
| return syncStatusNodePermissioningProvider; | |||
| } | |||
|
|
|||
| @VisibleForTesting | |||
| List<NodePermissioningProvider> getProviders() { | |||
| public List<NodePermissioningProvider> getProviders() { | |||
There was a problem hiding this comment.
Given that we are exposing our list of providers, would it make sense to change it to an unmodifiable list?
There was a problem hiding this comment.
Will go private again in PAN-2449
Errorific
deleted the
feature/PAN-2347.devp2p_nodepermissioningcontroller
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to make sure that incoming and outgoing devp2p connections are abiding by the nodePermissioningControllers rules. Also some associated quality of life refactors.