This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
Remove Peer json RPC added #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 15, 2019 15:43
The staticnodes.json file resides in the pantheon data directory, is parsed at startup to determine which peers can be connected to (aside from bootnodes), and is updated whenever addPeer/removePeer RPC is invoked. This file is not updated when finding neighbour peers (ONLY on RPC call).
rain-on
force-pushed
the
remove_peer_rpc
branch
from
14047ef to
08a377c
Compare
jframe
reviewed
Mar 20, 2019
| @@ -66,7 +67,11 @@ public int size() { | |||
| } | |||
|
|
|||
| public boolean isAlreadyConnected(final BytesValue nodeId) { | |||
| return connections.containsKey(nodeId); | |||
| return getConnectionForPeer(nodeId).isPresent(); | |||
There was a problem hiding this comment.
why did this need to change?
There was a problem hiding this comment.
Kinda preferred re-using the same interface as was now exposed ... but have changed it back.
| import org.junit.Test; | ||
| import org.junit.rules.TemporaryFolder; | ||
|
|
||
| public class StaticeNodesParserTest { |
There was a problem hiding this comment.
class name is misnamed. perhaps will be fixed by merge/rebase from master?
CjHare
reviewed
Mar 20, 2019
| import org.apache.logging.log4j.LogManager; | ||
| import org.apache.logging.log4j.Logger; | ||
|
|
||
| public abstract class AdminPeerModification implements JsonRpcMethod { |
There was a problem hiding this comment.
🤔 Something makes me think that AdminModifyPeer would be more consistent. (Noun-verb-noun instead of Noun-Noun-verb?)
CjHare
approved these changes
Mar 20, 2019
jframe
approved these changes
Mar 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemovePeer Json RPC has been added, it is responsible disconnecting from the specified peer and removing it from the maintained list of peers.