Skip to content
This repository has been archived by the owner on Sep 26, 2019. It is now read-only.

Uploading to Bintray as part of the release #105

Merged
merged 38 commits into from
Oct 19, 2018
Merged

Uploading to Bintray as part of the release #105

merged 38 commits into from
Oct 19, 2018

Conversation

CjHare
Copy link
Contributor

@CjHare CjHare commented Oct 19, 2018

PR description

Gradle release process needs to be uploading the Pantheon binaries to Bintray.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Related Issue(s)

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Release note

Gradle release task now also uploads and publishes to Bintray

Prerequisites:

  • I have read the CONTRIBUTING.md document and followed the guidelines there.
  • I have commented my code, particularly in hard-to-understand areas
  • I have opened an issue for corresponding changes to documentation (OR no doc changes required)
  • I have added appropriate tests that prove my change is effective

'GIT_COMMITTER_NAME="Pegasys Admin"',
'GIT_COMMITTER_EMAIL="pegasys.manager@gmail.com"',
'GIT_AUTHOR_NAME="Pegasys Admin"',
'GIT_AUTHOR_EMAIL="pegasys.manager@gmail.com"'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Pegasys/PegaSys

)
]) {
withEnv([
'GIT_COMMITTER_NAME="Pegasys Admin"',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Pegasys/PegaSys

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Errorific do the value here matter or can they be anything?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anythingish. They're meta data on github.

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES

@CjHare CjHare merged commit 5a89e7d into PegaSysEng:master Oct 19, 2018
@CjHare CjHare deleted the wip-release branch October 19, 2018 03:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants