Reduce Log Noise (#261)

Some more logging level downgrades. * At steady state we should get only one info level log per new block * We don't need to know about peer stuff at info * Caught up to best peer fires for every block
PegaSysEng · Nov 14, 2018 · 22ed035 · 22ed035
1 parent 22177b1
commit 22ed035
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/ethereum/eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/sync/Downloader.java b/ethereum/eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/sync/Downloader.java
@@ -151,7 +151,7 @@ private CompletableFuture<SyncTarget> findSyncTarget() {
       if (peerTd.compareTo(syncState.chainHeadTotalDifficulty()) <= 0
           && peerHeight <= syncState.chainHeadNumber()) {
         // We're caught up to our best peer, try again when a new peer connects
-        LOG.info("Caught up to best peer: " + bestPeer.chainState().getEstimatedHeight());
+        LOG.debug("Caught up to best peer: " + bestPeer.chainState().getEstimatedHeight());
         return waitForPeerAndThenSetSyncTarget();
       }
       return DetermineCommonAncestorTask.create(

diff --git a/...eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/sync/tasks/GetBlockFromPeerTask.java b/...eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/sync/tasks/GetBlockFromPeerTask.java
@@ -49,7 +49,7 @@ public static GetBlockFromPeerTask create(
 
   @Override
   protected void executeTaskWithPeer(final EthPeer peer) throws PeerNotConnected {
-    LOG.info("Downloading block {} from peer {}.", hash, peer);
+    LOG.debug("Downloading block {} from peer {}.", hash, peer);
     downloadHeader(peer)
         .thenCompose(this::completeBlock)
         .whenComplete(
@@ -61,7 +61,7 @@ protected void executeTaskWithPeer(final EthPeer peer) throws PeerNotConnected {
                 LOG.info("Failed to download block {} from peer {}.", hash, peer);
                 result.get().completeExceptionally(new IncompleteResultsException());
               } else {
-                LOG.info("Successfully downloaded block {} from peer {}.", hash, peer);
+                LOG.debug("Successfully downloaded block {} from peer {}.", hash, peer);
                 result.get().complete(new PeerTaskResult<>(r.getPeer(), r.getResult().get(0)));
               }
             });

diff --git a/...reum/eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/sync/tasks/WaitForPeerTask.java b/...reum/eth/src/main/java/tech/pegasys/pantheon/ethereum/eth/sync/tasks/WaitForPeerTask.java
@@ -37,15 +37,15 @@ public static WaitForPeerTask create(final EthContext ethContext) {
   @Override
   protected void executeTask() {
     final EthPeers ethPeers = ethContext.getEthPeers();
-    LOG.info(
+    LOG.debug(
         "Waiting for new peer connection. {} peers currently connected, {} idle.",
         ethPeers.peerCount(),
         ethPeers.idlePeer().isPresent() ? "Some peers" : "No peers");
     // Listen for peer connections and complete task when we hit our target
     peerListenerId =
         ethPeers.subscribeConnect(
             (peer) -> {
-              LOG.info("Finished waiting for peer connection.");
+              LOG.debug("Finished waiting for peer connection.");
               // We hit our target
               result.get().complete(null);
             });