add reverse proxy support for SSH and VNC websocket + nginx config#43
Open
aderumier wants to merge 1 commit intoPegaProx:mainfrom
Open
add reverse proxy support for SSH and VNC websocket + nginx config#43aderumier wants to merge 1 commit intoPegaProx:mainfrom
aderumier wants to merge 1 commit intoPegaProx:mainfrom
Conversation
Currently the vnc && ssh websockets ports send to the wss client are hardcoded to 5001 && 5002. This patch assume that if client use port 80/443, it's using a production reverse proxy, and reuse this port the websocket connections
Contributor
|
Hi @aderumier, Regards, |
Contributor
Author
|
hi, no problem, I'll look to add an option to enable reverse proxy, and find a way to return the correct port dynamically to the client. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the vnc && ssh websockets ports send to the wss client are hardcoded to 5001 && 5002.
This patch assume that if client use port 80/443, it's using a production reverse proxy, and reuse this port the websocket connections