Skip to content

Allow to connect to Mongo without readConcern: majority #3459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow to connect to Mongo without readConcern: majority #3459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16768c8
A lot simpler way to override read concern
ST-eugenekrivdyuk Sep 11, 2025
ca2594c
Fix syntax
ST-eugenekrivdyuk Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions flow/connectors/mongo/mongo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,13 @@
}).
// always use compression
SetCompressors([]string{"zstd", "snappy"}).
// always use majority read concern for correctness
SetReadConcern(readconcern.Majority()).
SetDialer(&meteredDialer)

// read concern could be set in the connection string with "readConcernLevel=[local|available|majority|...]"

Check failure on line 137 in flow/connectors/mongo/mongo.go

View workflow job for this annotation

GitHub Actions / lint 

File is not properly formatted (gci)
if connStr.ReadConcernLevel == "" {
clientOptions.SetReadConcern(readconcern.Majority())
}

switch config.ReadPreference {
case protos.ReadPreference_PRIMARY:
clientOptions.SetReadPreference(readpref.Primary())
Expand Down
Loading