pg: detect when partitioning fails due to timescale compressed tables #3283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
force-pushed
the
timescale-full-table-partition
branch
from
e777b89 to
4c953a3
Compare
…, & fallback to not using ctid
serprex
force-pushed
the
timescale-full-table-partition
branch
from
4c953a3 to
9be2ead
Compare
| var pgErr *pgconn.PgError | ||
| if config.WatermarkColumn == "ctid" && errors.As(err, &pgErr) && | ||
| pgErr.Message == "transparent decompression only supports tableoid system column" { | ||
| // timescale, fallback to full table partition |
There was a problem hiding this comment.
please add a log here to indicate switch
|
superseded by #3318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
& fallback to not using ctid