[mysql] move validation to shared for reuse

[heavycrystal]

No description provided.

[Copilot]

Pull Request Overview

This PR centralizes MySQL validation routines into a shared package and updates the MySQL connector to leverage these shared functions.

• Extract MySQL version and binlog validation into flow/shared/mysql/validation.go
• Refactor flow/connectors/mysql/validate.go to call shared validation, remove duplicated logic, and incorporate retry logic
• Update imports and error handling to use the new shared package

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
flow/shared/mysql/validation.go	New shared MySQL validation functions (version, flavor, binlog)
flow/connectors/mysql/validate.go	Connector refactor to use shared validation and withRetries API

Comments suppressed due to low confidence (2)

flow/shared/mysql/validation.go:17

• These new exported validation functions lack accompanying unit tests. Consider adding tests for version comparison, flavor validation, and each binlog settings checker to ensure correct behavior across MySQL/MariaDB versions.

func CompareServerVersion(conn *client.Conn, version string) (int, error) {

flow/shared/mysql/validation.go:17

• Add Go doc comments for each exported function (e.g., // CompareServerVersion compares the server version to the target version and returns an integer result.) to improve maintainability and generated documentation.

func CompareServerVersion(conn *client.Conn, version string) (int, error) {

[Copilot]

Passing slog.Any("error", err) into a log.Logger may not render as expected. Use key/value pairs directly: logger.Warn("...", "error", err).

Suggested change

	slog.Any("error", err))
	"error", err)