Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nexus: aws-lc-rs #2715

Merged
merged 1 commit into from
Mar 17, 2025
Merged

nexus: aws-lc-rs #2715

merged 1 commit into from
Mar 17, 2025

Conversation

serprex
Copy link
Member

@serprex serprex commented Mar 17, 2025

with #2712 we've added aws-lc-rs to our dependencies

ring recently lost some confidence with briansmith/ring#2414

switch to using aws-lc-rs ourselves. ring remains a downstream dependency

with #2712 we've added aws-lc-rs to our dependencies

ring recently lost some confidence with briansmith/ring#2414

switch to using aws-lc-rs ourselves. ring remains a downstream dependency
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.02%. Comparing base (9531302) to head (7970c4f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2715      +/-   ##
==========================================
- Coverage   43.06%   43.02%   -0.04%     
==========================================
  Files         172      172              
  Lines       26025    26025              
==========================================
- Hits        11207    11197      -10     
- Misses      13509    13514       +5     
- Partials     1309     1314       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@serprex serprex enabled auto-merge (squash) March 17, 2025 19:55
@serprex serprex merged commit e642d76 into main Mar 17, 2025
15 of 16 checks passed
@serprex serprex deleted the aws-lc-rs branch March 17, 2025 20:03
Amogh-Bharadwaj pushed a commit that referenced this pull request Mar 18, 2025
with #2712 we've added aws-lc-rs to our dependencies

ring recently lost some confidence with briansmith/ring#2414

switch to using aws-lc-rs ourselves. ring remains a downstream dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants