Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(classifier): mark ch auth failures as recoverable and push out ch error code always #2679

Merged
merged 1 commit into from
Mar 10, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions flow/alerting/classifier.go
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,8 @@ func GetErrorClass(ctx context.Context, err error) (ErrorClass, ErrorInfo) {
chproto.ErrUnfinished,
chproto.ErrAborted:
return ErrorInternalClickHouse, chErrorInfo
case chproto.ErrAuthenticationFailed:
return ErrorRetryRecoverable, chErrorInfo
default:
if isClickHouseMvError(chException) {
return ErrorNotifyMVOrView, chErrorInfo
Expand All @@ -246,6 +248,7 @@ func GetErrorClass(ctx context.Context, err error) (ErrorClass, ErrorInfo) {
// notify if normalization hits error on destination
return ErrorNormalize, chErrorInfo
}
return ErrorOther, chErrorInfo
}
}

Expand Down