Skip to content

Fix long certificate filenames in files export - #116

Merged
WorldThirteen merged 1 commit into
masterfrom
fix-files-export-long-ski
Jun 9, 2026
Merged

Fix long certificate filenames in files export#116
WorldThirteen merged 1 commit into
masterfrom
fix-files-export-long-ski

Conversation

@WorldThirteen

Copy link
Copy Markdown
Collaborator

Fixes --format files exports when certificates contain missing or unusually large Subject Key Identifier values.

The files export now derives certificate filenames as follows:

  • use the uppercase hex-encoded Subject Key Identifier when it is 64 characters or shorter
  • use the uppercase SHA-1 hash of the raw Subject Key Identifier value when the SKI is longer than 64 characters
  • use the uppercase SHA-1 hash of the raw subject public key bit string when the SKI is missing

Previously Mozilla TL had such certificates that were not able to be written into fs due to long filename.

The filename derivation rules are documented in the README.

@WorldThirteen
WorldThirteen requested a review from microshine June 9, 2026 14:07
@WorldThirteen
WorldThirteen merged commit 133ab36 into master Jun 9, 2026
2 checks passed
@WorldThirteen
WorldThirteen deleted the fix-files-export-long-ski branch June 9, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants