Closed
Rename nppStorage to woodCStorageDelta for clarity#252
Conversation
7 tasks
Co-authored-by: dlebauer <464871+dlebauer@users.noreply.github.com>
Co-authored-by: dlebauer <464871+dlebauer@users.noreply.github.com>
Co-authored-by: dlebauer <464871+dlebauer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update implementation for carbon balance check without ctx.microbes
Rename nppStorage to woodCStorageDelta for clarity
Feb 5, 2026
Collaborator
|
This is out of date, change made elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from @dlebauer to rename
nppStoragetowoodCStorageDelta, clarifying that this variable represents a carbon-only storage delta rather than a generic NPP storage pool.Changes
Variable rename:
nppStorage→woodCStorageDeltain:state.h)balance.c)sipnet.c)smoke_check.py, test output files)Added to
.gitignore: CodeQL build artifacts (_codeql_build_dir/,_codeql_detected_source_root)The new name makes explicit that this is an abstract bookkeeping term for carbon storage changes in wood biomass, consistent with the decision to exclude nitrogen from this pool given the fixed C:N ratios in plant biomass.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.