Skip to content

Conversation

@AritraDey-Dev
Copy link
Member

@AritraDey-Dev AritraDey-Dev commented Jan 21, 2026

Description

Fix ci failure for R 4.2
https://github.com/PecanProject/pecan/actions/runs/21185564344/job/60939202625
https://github.com/PecanProject/pecan/actions/runs/21185564344/job/60939202582

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I agree that PEcAn Project may distribute my contribution under any or all of
    • the same license as the existing code,
    • and/or the BSD 3-clause license.
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev AritraDey-Dev changed the title Fix CI failure pin xfun 0.39 only for R 4.2 Fix CI failure: pin xfun 0.39 only for R 4.2 Jan 21, 2026
@infotroph
Copy link
Member

Thanks for working on this. Let's dig a little further before merging -- my bias is that adding more complexity to the Makefile should be a ~last resort, and this is tripping my "feels like the real problem might be elsewhere" spidey sense.

Specifically:

  • Both those runs installed roxygen2 7.3.2 as a binary in the last step of the "install new dependencies" step, so I'm not sure why the Make roxygen step is firing at all
  • Then once it decides to reinstall Roxygen, I'm not sure how it's picking up a different xfun: The R4.2 image installs packages from a static CRAN snapshot, so I don't know what would have changed. I don't see xfun listed in the updates earlier in the log.

@AritraDey-Dev
Copy link
Member Author

Both those runs installed roxygen2 7.3.2 as a binary in the last step of the "install new dependencies" step, so I'm not sure why the Make roxygen step is firing at all

since xfun isn't in pecan_package_dependencies.csv, so it's not pinned,so when docker/depends/pecan.depends.R installs roxygen2 7.3.2 with dependencies = TRUE, it pulls in xfun as a transitive dependency, roxygen2 7.3.2 allows xfun >= 0.30, so newer versions (>= 0.40) get installed, which don't have xfun::attr

@AritraDey-Dev
Copy link
Member Author

i believe most proper solution in this case will be to install the xfun specifc version in docker/depends/pecan.depends.R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants