Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margin-top from panel when it is first-child #265

Open
erikhallaraaker opened this issue Mar 12, 2019 · 1 comment
Open

Remove margin-top from panel when it is first-child #265

erikhallaraaker opened this issue Mar 12, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@erikhallaraaker
Copy link
Contributor

All panels have margin-top: 1rem, which is good as panels usually needs some spacing. It is however, unfortunate that the first child also has this margin, as the panel is usually a direct child of a col and that makes it not line up with other content.

I propose to rewrite the panel rule to the following:

.panel {
    &:not(:first-child) {
        margin-top: 1rem;
    }
}
@Akswii
Copy link
Contributor

Akswii commented May 20, 2019

We see the issue, but this is relates to more than just margin-top for panels. We will need to take a look at how components relate to each other before making a decision.

@Akswii Akswii added the enhancement New feature or request label May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants