You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The line height and margin between the list items is the same. The space between the list items is now only based on the global line height.
Should we have 1.75 line height base?
Won't this make it harder to work with text in components, and cause a loot of overriding?
This will affect text of different sizes, to inherit the line-height of the body font-size (16px).
Every element with a custom text size will now also need a custom line-height to not end up with a 1.75 line-height for 16px. In other words, an element with font-size 100px and font-size 10px will now have the same line-height.
After some input from @asbjornu; removing the unit (rem) will fix the text-with-different-sizes-issue mentioned above (https://stackoverflow.com/a/12304722/61818). Stil a question if we should have the default at 1.75 though.
Describe the bug
The line height and margin between the list items is the same. The space between the list items is now only based on the global line height.
design.payex.com/src/less/core/global.less
Lines 29 to 36 in 76bfd0c
Should we have 1.75 line height base?
Won't this make it harder to work with text in components, and cause a loot of overriding?
This will affect text of different sizes, to inherit the line-height of the body font-size (16px).
Every element with a custom text size will now also need a custom line-height to not end up with a 1.75 line-height for 16px. In other words, an element with font-size 100px and font-size 10px will now have the same line-height.
To Reproduce
Screenshots
Desktop:
The text was updated successfully, but these errors were encountered: