fix:shouldTriggerOnSuccess amount validate #514
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lissavxo
force-pushed
the
fix/should-trigger-success-amount
branch
from
7d32c51 to
dd92787
Compare
|
How can I see what is this fixing? what is the test plan? |
|
Is this tied to any task (eg. #318)? |
just make sure the onSuccess behavior is happening as expected |
|
I am not sure how to reproduce this error so I am leaving it on hold for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
Description
Small fix in shouldTriggerOnSuccess function to get the amount from currencyObject.
Sometimes we call
shouldTriggerOnSuccessfunction withcurrencyObjectbut there is no need to convert the amount to value because thecurrencyObject.currencyis crypto currency. This PR checks ifcurrencyObject.currencyis crypto currency and it converts amount to value only ifcurrencyObject.currencyis fiat.Test plan