Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Main Config #82

Merged
merged 2 commits into from
Nov 2, 2021
Merged

Conversation

ComputerNerd100
Copy link
Collaborator

Fixes #72
Removes the Main Config, and associated Updater class, as these are no longer used.

Fixes Paul19988#72
Removes the Main Config, and associated Updater class, as these are no longer used.
@ComputerNerd100
Copy link
Collaborator Author

I've left this as draft for now - I've removed the main config and have also removed the Updater class from the update package, however there's also a Version class left in there as well which now isn't used anywhere. Should I remove this too?

@b0ykoe
Copy link
Collaborator

b0ykoe commented Oct 28, 2021

The Version class can be removed. For now we're not offering any update service and as soon as we do we most likely implement our own logic.

Fixes Paul19988#72
Removes remaining unused versioning classes, and update package
@ComputerNerd100 ComputerNerd100 marked this pull request as ready for review October 30, 2021 10:27
@ComputerNerd100
Copy link
Collaborator Author

Final changes pushed and PR released for review :)

@Paul19988 Paul19988 merged commit 4b93431 into Paul19988:develop Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated config is literally "null"
3 participants