updated deps & readme, cleaned up scripts #1367
Conversation
colinskow
force-pushed
the
update-deps
branch
from
494e514 to
bc2de38
Compare
|
Protractor ^5.0.0 dropped support Node 5. If we want to update Protractor further we will need to drop support for Node 5. In my opinion we should support only Node lastest and Node LTS. |
colinskow
force-pushed
the
update-deps
branch
from
bc2de38 to
43c70b4
Compare
colinskow
force-pushed
the
update-deps
branch
from
43c70b4 to
a7568a6
Compare
| @@ -142,10 +141,10 @@ | |||
| "ts-node": "^2.0.0", | |||
| "tslint": "~4.3.1", | |||
| "typedoc": "^0.5.3", | |||
| "typescript": "2.0.10", | |||
| "typescript": "~2.1.5", | |||
There was a problem hiding this comment.
Unless Angular has changed their stance on this and resolved the AOT issues, this should not be changed as last I checked it isn't officially supported until Angular 4.x
There was a problem hiding this comment.
In Angular 2.3.x with TS 2.1.x the NGC compiler left the compiled directory mostly empty and didn't generate the ngfactory files. Now with Angular 2.4.3 our AoT build works perfectly with TypeScript 2.1 and the tests are passing with flying colors.
While the issue technically hasn't been closed yet, the problem seems to have been fixed. My opinion is that it is safe to merge since the tests that failed before due to the issue are now passing.
There was a problem hiding this comment.
It seems that TS 2.1 is still not supported for AOT: angular/angular#13294
There was a problem hiding this comment.
@pglazkov This is really interesting... I wonder why they say it's not working.
I did some crazy things with typescript nightly with no issues... AOT 100%
I wonder if it's ngc-webpack to "blame"
There was a problem hiding this comment.
I'm running TypeScirpt 2.1.5 in production on Angular 2.4.3 and I have no issues with AOT compilation in either of my largest apps.
Perhaps it would be more accurate to say that isn't flakey. The language service issue was the initial blocker to TypeScript 2.1 which is referenced above.
I do on the other hand compile my AOT with ngc directly which may support the ngc-webpack theory.
|
@katallaxie you haven't submitted a pull request for i18n yet! |
Resolves #1353