Skip to content

Feat/custom network page#4

Merged
PatrickAlphaC merged 2 commits intoeternalsafefrom
feat/custom-network-page
Apr 26, 2025
Merged

Feat/custom network page#4
PatrickAlphaC merged 2 commits intoeternalsafefrom
feat/custom-network-page

Conversation

@PatrickAlphaC
Copy link
Owner

What it solves

Resolves #

How this PR fixes it

How to test it

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@PatrickAlphaC PatrickAlphaC merged commit 35e4144 into eternalsafe Apr 26, 2025
1 of 3 checks passed
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

Comment on lines +115 to +121
<ReviewRow
name="Multisend Address"
value={
<Typography>
{data.multisendAddress}
</Typography>
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace ⏎··············name="Multisend·Address"⏎··············value={⏎················<Typography>⏎··················{data.multisendAddress}⏎················</Typography>⏎··············} with ·name="Multisend·Address"·value={<Typography>{data.multisendAddress}</Typography>}·/> prettier/prettier

Fix available:

Suggested change
<ReviewRow
name="Multisend Address"
value={
<Typography>
{data.multisendAddress}
</Typography>
}
<ReviewRow name="Multisend Address" value={<Typography>{data.multisendAddress}</Typography>} />

{data.multisendAddress}
</Typography>
}
/>)}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete ··/> prettier/prettier

Fix available:

Suggested change
/>)}
)}

Comment on lines +126 to +130
value={
<Typography>
{data.multisendCallOnlyAddress}
</Typography>
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace ⏎················<Typography>⏎··················{data.multisendCallOnlyAddress}⏎················</Typography>⏎·············· with <Typography>{data.multisendCallOnlyAddress}</Typography> prettier/prettier

Fix available:

Suggested change
value={
<Typography>
{data.multisendCallOnlyAddress}
</Typography>
}
value={<Typography>{data.multisendCallOnlyAddress}</Typography>}

{data.multisendCallOnlyAddress}
</Typography>
}
/>)}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insert ⏎·········· prettier/prettier

Fix available:

Suggested change
/>)}
/>
)}

const { chainId, address, owners, threshold, multisendAddress, multisendCallOnlyAddress } = payload.safe

state[chainId] ??= {}
const existingData = state[chainId][address.value] ?? {};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete ; prettier/prettier

Fix available:

Suggested change
const existingData = state[chainId][address.value] ?? {};
const existingData = state[chainId][address.value] ?? {}

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 74.05% 6176/8340
🔴 Branches 50.07% 1365/2726
🔴 Functions 55.82% 902/1616
🟡 Lines 76.14% 5538/7273

Test suite run success

761 tests passing in 120 suites.

Report generated by 🧪jest coverage report action from 8be4b44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant