269 final code cleanup for public release #274
Conversation
move setCANTimeout to constructor & ensure current limit gets set
…a fork off of #269 before it went south ❌❌❌
…ithub.com/patribots4738/Crescendo2024 into 269-final-code-cleanup-for-public-release
…ithub.com/Patribots4738/Crescendo2024 into 269-final-code-cleanup-for-public-release
…ithub.com/Patribots4738/Crescendo2024 into 269-final-code-cleanup-for-public-release
This reverts commit 73009e2.
Jacob1010-h
requested review from
RudyG252 and
GalexY727
and removed request for
RudyG252
make safespark a part of sim and testing just so sdahgyudfgahjd
|
just merged in static boi,everything should be good to go, besides the merge conflict. I world love to get this public before or during lunch |
…into 269-final-code-cleanup-for-public-release
…ithub.com/Patribots4738/Crescendo2024 into 269-final-code-cleanup-for-public-release
There was a problem hiding this comment.
due to the extreme fundemental changes that come along with this branch, while some of these changes are for the better I think I would like to push off this PR until after Bayou (or worlds) since I am worried if a single thing was overlooked it would backfire on us pretty hard.
There was a problem hiding this comment.
I'm not a huge fan of this file. At least, it should be renamed to something more fitting. Something like LoggedValues or something... just not RobotState. It does not represent the current state of the robot and we don't need to be like 254.
There was a problem hiding this comment.
? oh i didnt know they did that, that was just the first thing that I thought of. Ill rename it.
There was a problem hiding this comment.
All good, that original comment was very.... aggressive. I apologize for that tone.
|
I agree, if we end up going to Bayou or worlds, then we should wait. |
There was a problem hiding this comment.
I in fact never tested this and would still like to keep it in todos, for future reference.
There was a problem hiding this comment.
Everything on this branch has been tested in sim, however it's possible I overlooked something and I would like to actually test it on the bot when we plan on merging this branch into main.
|
I am going to reopen this and make this a draft, because we can do that now that the repo is public!! |
|
tbh, i think that the folder paths in main are good, thinking about it further. When I think of a file, the only path to get there would be to follow the folders, and the folder names explain the purpose of everything inside of it which is how it is supposed to be |
So you think that the folder paths we have in main area the better option? |
|
yes |
No description provided.