Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MAXSwereModule better #124

Merged
merged 6 commits into from
Feb 3, 2024
Merged

Make MAXSwereModule better #124

merged 6 commits into from
Feb 3, 2024

Conversation

Hadizah454
Copy link
Contributor

We got rid of unnecessary calls to encoders.

@Hadizah454 @rin-star @derp00monsta
Make MAXSwereModule better
e55d59d 
Co-authored-by: rin-star <rin-star@users.noreply.github.com>
Co-authored-by: Tina H <derp00monsta@users.noreply.github.com>
@Hadizah454 Hadizah454 self-assigned this Feb 3, 2024
GalexY727
GalexY727 requested changes Feb 3, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, I really like this overall though

src/main/java/frc/robot/util/MAXSwerveModule.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/Neo.java Outdated Show resolved Hide resolved
GalexY727
GalexY727 requested changes Feb 3, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused objects in Neo. Then we are good to go :D

src/main/java/frc/robot/util/Neo.java Outdated Show resolved Hide resolved
GalexY727
GalexY727 approved these changes Feb 3, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yayy

@GalexY727 GalexY727 merged commit 68f43a7 into main Feb 3, 2024
1 check passed
@GalexY727 GalexY727 deleted the 100-maxswervemodulejava-health-and-wellness branch February 3, 2024 22:29
Oliver-Cushman added a commit that referenced this pull request Feb 3, 2024
@Oliver-Cushman
Revert "Make MAXSwereModule better (#124)"
00d9a5a 
This reverts commit 68f43a7, reversing
changes made to 5da8c19.
@Oliver-Cushman
Copy link
Contributor

bro did not make MAXSwerveModule better

@Oliver-Cushman Oliver-Cushman restored the 100-maxswervemodulejava-health-and-wellness branch February 3, 2024 23:22
@Hadizah454
Copy link
Contributor Author

@Oliver-Cushman what suggestions do you have to make it better?

@GalexY727
Copy link
Member

If you run it in sim you might find pretty quickly that there is something extremely off with the branch-- I have no idea what the issue is but it.. exists

@Hadizah454
Copy link
Contributor Author

Oh ok I'll look into it.

@GalexY727
Copy link
Member

I explain it in a bit more detail in #129

@Hadizah454
Copy link
Contributor Author

ok I get it I'll try to check it out on Tuesday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalexY727 GalexY727 GalexY727 approved these changes

Assignees

@Hadizah454 Hadizah454

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Hadizah454 @Oliver-Cushman @GalexY727 @PatribotsProgramming