Attempt user fetch only if patron access token is not null #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
getPatreonUser
function attempts to fetch user data as longas
access_token != ''
. This check does not account for the accesstoken being
null
. Access token data can be set tonull
if a tokenrefresh failed. Because of this, the app might be attempting to refresh
user tokens even of no token is available.
Solution
Use
empty
which checks for both -null
and''
.