Use old way of showing author names when the author profiles is missing in summary page. #912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rofiles data is missing. Also, use span for author names when the author page link is missing as it is used to be.
|
When I try to view prod rethinkdb data with this PR, the author names are space-delimited. Are we OK with this? It looks a bit odd but its not a showstopper.
|
|
I suspect Metin did this so that you don’t accidentally click on one author name accidentally — just because it happened to be close to another name. I’m agnostic to whether we use spaces or commas. In the comma case, it could look a bit weird to have the extra space between names, e.g.:
Oliver Hardy, ___ Stan Laurel, ___ Bud Abbott, ___ Lou Costello
In any case, this can be revised with just css, e.g. `&::after { content: ‘, ' }`
… On Dec 7, 2020, at 4:59 PM, Jeffrey ***@***.***> wrote:
When I try to view prod rethinkdb data with this PR, the author names are space-delimited. Are we OK with this? It looks a bit odd but its not a showstopper.
<https://user-images.githubusercontent.com/4706307/101410514-777b5080-38ad-11eb-850c-81d9086b53db.png>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#912 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHRO46EHFD45GP4AAUTVZLSTVF43ANCNFSM4ULAOAZA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #910 (comment)