Iss860 empty submit iss861 irregular org #868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create task list component
- Add components for closing tooltip on click
|
Looks good, but I'd just remove the button rather than disable it. Invariably, someone's going to try to click the greyed out button anyway. |
|
Maybe 'show me how' could be a salient button instead of link. |
|
|
|
Do we care about the tooltip closing when the help is open? If not then this one is good to go. |
|
Does the submit tooltip stay open after you close the help? If so, the submit tooltip should be closed on click.
… On Oct 9, 2020, at 1:40 PM, Jeffrey ***@***.***> wrote:
Do we care about the tooltip closing when the help is open? If not then this one is good to go.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#868 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHRO463NNUX2O4R6MQSXULSJ5DI7ANCNFSM4SKG7WEQ>.
|
No everything closes. |
|
OK then it’s good to go
… On Oct 9, 2020, at 1:47 PM, Jeffrey ***@***.***> wrote:
Does the submit tooltip stay open after you close the help? If so, the submit tooltip should be closed on click.
No everything closes.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#868 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHRO455CGXK3FBOID5L72DSJ5EEXANCNFSM4SKG7WEQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add warnings in the submit tooltip:
Here, the 'show me help' toggles the help, but I am having trouble understanding how to close the tooltip on clicking the hypertext.
Refs #860 and #861