Skip to content

More informative logging #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2024
Merged

More informative logging #1253

merged 3 commits into from
Apr 25, 2024

Conversation

@jvwong
Copy link
Member

@jvwong jvwong commented Apr 25, 2024

Logging changes so we don't lose the ability to identify useful info:

  • Identify the exact source and type of Error being thrown, namely the PubMed and Crossref resources
  • Differentiate between debug and info-level items more appropriately (e.g. HTTP 429 is important)
  • For HTTPStatusError, provide access to the fetch response, so we can track headers being sent back (e.g. HTTP 429)

Refs #1251

@jvwong jvwong merged commit ff496b5 into unstable Apr 25, 2024
@jvwong jvwong deleted the iss1251_more-informative-error-logging branch April 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jvwong