Skip to content

Extract string tests for items that resemble DOIs and PMIDs #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2023
Merged

Extract string tests for items that resemble DOIs and PMIDs #1212

merged 1 commit into from
Oct 19, 2023

Conversation

@jvwong
Copy link
Member

@jvwong jvwong commented Oct 12, 2023

Checking for a DOI-like string comes up more often, especially when extracting from plain text fields.

@jvwong jvwong requested a review from maxkfranz October 12, 2023 15:37
maxkfranz
maxkfranz approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@maxkfranz maxkfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for Crossref.

We may have to revisit for other systems in future. For now, good enough.

@jvwong jvwong merged commit a6f0a43 into unstable Oct 19, 2023
@jvwong jvwong deleted the iss1201_extract-doi-test branch October 26, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maxkfranz maxkfranz maxkfranz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvwong @maxkfranz