Skip to content

Conversation

@jvwong
Copy link
Member

@jvwong jvwong commented Feb 16, 2023

  • Configurable variables for the graph database (Neo4j)
  • Driver code initializes if doesn't exist
  • tests.

@jvwong jvwong requested a review from lindajiawenli February 16, 2023 23:07
@lindajiawenli
Copy link
Contributor

Hi @jvwong, it looks good to me! Definitely an improvement over the connect-neo4j.js edits I made over at my pr.
Good call making the username and password "undefined" instead of just ignoring it like I did!

Is this ready to be merged?

@jvwong
Copy link
Member Author

jvwong commented Feb 17, 2023

Hi @jvwong, it looks good to me! Definitely an improvement over the connect-neo4j.js edits I made over at my pr. Good call making the username and password "undefined" instead of just ignoring it like I did!

Is this ready to be merged?

Sure I'll merge it in. You'll have to update your unstable branch locally, then you might want to add these changes to your test PR/branch. I don't think there will be conflicts (these updates and your updates overlap). In either case I figured this was a good practice of collab coding.

@jvwong
Copy link
Member Author

jvwong commented Feb 17, 2023

One more thing @lindajiawenli - the docs say that Driver.verifyConnectivity is deprecated (but only for some return type). So anyways that's why I got rid of it.

@jvwong jvwong merged commit c4096df into unstable Feb 17, 2023
@lindajiawenli
Copy link
Contributor

Yeah I noticed that too! Thanks for working around it.

@jvwong jvwong deleted the iss1122_uri-config branch February 17, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants