Skip to content

Conversation

@lindajiawenli
Copy link
Contributor

Adding the starting-neo4j.js file (code from Max earlier today)

@jvwong
Copy link
Member

jvwong commented Feb 2, 2023

Re package-lock.json: unless you've updated the npm packages in package.json, you probably don't want to include this

@lindajiawenli lindajiawenli marked this pull request as draft February 3, 2023 14:01
@lindajiawenli lindajiawenli self-assigned this Feb 3, 2023
@lindajiawenli
Copy link
Contributor Author

Re package-lock.json: unless you've updated the npm packages in package.json, you probably don't want to include this

Hi, thanks for letting me know, I'll definitely watch out for that in the future!

@lindajiawenli lindajiawenli marked this pull request as ready for review February 3, 2023 16:19
@maxkfranz
Copy link
Member

Great. Just make sure that each time you make a PR that you set the target branch as unstable, like you did in this PR.

Let's merge this in

@lindajiawenli lindajiawenli merged commit f193276 into unstable Feb 6, 2023
@jvwong
Copy link
Member

jvwong commented Feb 6, 2023

FYI @lindajiawenli should run npm run lint to catch the linting errors.

@jvwong jvwong deleted the neo4j_branch branch February 6, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants