Skip to content

Sitemap tests #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 6, 2022
Merged

Sitemap tests #1089

merged 2 commits into from
Oct 6, 2022

Conversation

@jvwong
Copy link
Member

@jvwong jvwong commented Oct 6, 2022

  1. Run tests recursively
  2. Fix up sitemap tests (function expects output of Document.json(), i.e. Date objects)

Refs #1088

@jvwong jvwong requested a review from metincansiper October 6, 2022 16:47
metincansiper
metincansiper approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@metincansiper metincansiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jvwong jvwong merged commit c623249 into unstable Oct 6, 2022
@jvwong jvwong deleted the iss1088_sitemap-tests branch October 6, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@metincansiper metincansiper metincansiper approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvwong @metincansiper