Database labels #783
Merged
Database labels #783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvwong
reviewed
May 26, 2018
| const splitId=id.split(':'); | ||
|
|
||
| //Parse the query based on the format | ||
| if(/uniprot:\w+$/.test(id)) { |
There was a problem hiding this comment.
i.e. the prefix part (id is case-sensitive)
jvwong
reviewed
May 26, 2018
| body:JSON.stringify(query) | ||
| }).then(res => res.json()).then(ids=> _.assign(ids,{unrecognized:_.tail(ids.unrecognized)}));//remove padding | ||
| if(query.genes.length>=1){ | ||
| query.genes= query.genes; |
There was a problem hiding this comment.
Jeff, what do you mean by 'necessary'?
There was a problem hiding this comment.
I'm referring to line 35 query.genes= query.genes;. Isn't this assigning a variable reference to itself?
jvwong
requested changes
May 26, 2018
There was a problem hiding this comment.
One addition: For viewing interactions link, use 'HGNC Approved Symbol' as the source url parameters rather than NCBI Gene IDs. That is, in landing-box.js:
const landingBox = (props) => {
...
interactionsLink(box.databaseID,'View Interactions')
...
return h('div.search-landing',landingHTML);
};
...box.databaseID should always be HGNC approved symbol.
|
Please, do not insert word "approved" into "HGNC Symbol" (official primary name for that resource, ID type) anywhere. |
1. Format validator is now case insensitive (ps: this function only validate the format of query, so whether the id is case-sensitive does not affect the output) 2. Links to interation pages now use HGNC symbol rather than NCBI Gene ID
jvwong
approved these changes
May 28, 2018
|
Ah, Jeff was quick to merge this before me (I was just testing...) Great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Landing page now can accept query token in the form of
<database name>: <id>http://appsbeta.pathwaycommons.org/search?gt=0<=250&q=hgnc:ATM&type=Pathway and
http://appsbeta.pathwaycommons.org/search?gt=0<=250&q=ATM&type=Pathway will have same result.
Ref: #702