Infobox text and URI change #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! I think it makes sense for the text in the UI to just say "HGNC". Users don't really care how the link is made. |
Name of database NGNC changes from "NGNC Symbol" to "NGNC"
Originally, the text is the same as searching name . For example, if searching "HGNC Symbol", the displayed text will show "HGNC Symbol". Adding displayName can customize the displayed text.
|
@d2fong The text and link are updated. Could you review? |
d2fong
suggested changes
May 18, 2018
| usedDatabases.forEach((usedDatabase)=>{ | ||
| let dbLink = dbs[usedDatabase.configName]; | ||
| if (dbLink != null) { | ||
| links.push({"link":dbLink,"displayName":usedDatabase.displayName}); |
There was a problem hiding this comment.
- This is a minor nitpick but to keep the coding style consistent: for object keys you generally don't need to use strings you can just do something like this.
links.push({ link: dbLink, displayName: usedDatabase.displayName });
There was a problem hiding this comment.
The only place where quotation marks are mandatory on keys is in JSON files.
jvwong
reviewed
May 18, 2018
| ['GeneID',{configName:'NCBI Gene',gProfiler:'NCBIGene'}], | ||
| ['Uniprot',{configName:'Uniprot',gProfiler:'Uniprot'}] | ||
| ['GeneCards',{configName:'Gene Cards',gProfiler:'HGNCSYMBOL',displayName:'Gene Cards'}], | ||
| ['HGNC Symbol',{configName:'HGNC Symbol',gProfiler:'HGNCSymbol',displayName:'NGNC'}], |
d2fong
approved these changes
May 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In search info box, the text and link of HGNC are changed (ref. #756 ):
http://identifiers.org/hgnc.symbol/<HGNC approved symbol>Before:
After: