Add support for Foulborn Ancestral Vision#9299
Merged
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom Nov 21, 2025
Merged
Add support for Foulborn Ancestral Vision#9299LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
LocalIdentity merged 2 commits intoPathOfBuildingCommunity:devfrom
Conversation
Wires77
reviewed
Nov 20, 2025
Member
Wires77
left a comment
There was a problem hiding this comment.
The hardcoded item name won't make sense if another mod is added like this in the future.
We'll also run into issues in that case because you're summing the percentages instead of using MAX. So if both methods are used you'd be getting 100% conversion to defend with 400% of armor.
LocalIdentity
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Supports "modifiers to chance to suppress also apply to chance to defend with 200% of armour at 50% of their value".
Steps taken to verify a working solution:
Link to a build that showcases this PR:
After screenshot: