Fix Heraldry not granting Exposure to enemies#9179
Merged
LocalIdentity merged 4 commits intodevfrom Nov 15, 2025
Merged
Conversation
With my change in #9173, I moved the place in the file where EnemyModifiers were calculated but didn't realise that they also need to be recalculated later so that mods that rely on "AffectedBy" x still work Changed it to use a cache so it doesn't duplicate earlier added mods
Wires77
approved these changes
Nov 5, 2025
Member
Wires77
left a comment
Wires77
left a comment
There was a problem hiding this comment.
Consider adding a test case for this and Dying Breath, but otherwise looks good
added 3 commits
November 6, 2025 08:02
LocalIdentity
added
the
pob2
LocalIdentity
pushed a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Dec 15, 2025
LocalIdentity
added a commit
to PathOfBuildingCommunity/PathOfBuilding-PoE2
that referenced
this pull request
Dec 15, 2025
* Apply changes from PathOfBuildingCommunity/PathOfBuilding#9173 * Fix merge conflict * Fix from #9179 Fix from PathOfBuildingCommunity/PathOfBuilding#9179 * Fix from #9264) Fix from PathOfBuildingCommunity/PathOfBuilding#9264 * Fix typo * Try different weapon * Remove tests --------- Co-authored-by: LocalIdentity <LocalIdentity@users.noreply.github.com> Co-authored-by: LocalIdentity <localidentity2@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9178, Fixes #9182
With my change in #9173, I moved the place in the file where EnemyModifiers were calculated but didn't realise that they also need to be recalculated later so that mods that rely on "AffectedBy" x still work
Changed it to use a cache so it doesn't duplicate earlier added mods