Skip to content

Add support for new & reworked Assassin Ascendancy nodes #9025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2025
Merged

Add support for new & reworked Assassin Ascendancy nodes #9025

merged 2 commits into from
Oct 30, 2025

Conversation

@majochem
Copy link
Contributor

@majochem majochem commented Oct 24, 2025 •
edited
Loading

Adds support for:

  • 35% less Damage taken while there are at least two Rare or Unique Enemies nearby
  • 100% more Critical Strike Chance against Enemies that are not on Low Life
  • +100% to Critical Strike Multiplier against Enemies that are not on Low Life
  • Trigger Level 30 Assassin's Mark on Attack Critical Strike against a Rare or Unique Enemy and you have no Mark
  • Mark Skills Cost no Mana
  • Marked Enemy cannot Evade Attacks

Steps taken to verify a working solution:

  • Mods parsed correctly
    • Damage reduction works
    • Crit chance & crit multi work
    • Cannot evade works
    • Mana cost reduction works
    • Assasin's Mark granted (at correct level)

Limitation:

  • Due to the way "LowLife" condition is handled atm, "not on low life" is always true by default

Link to a build that showcases this PR:

Test Build with Assassin mods on amulet

After screenshot:

image image image image image image

@majochem
Change globalLimitKey to DurationPerPoisonRecently
53be5b3 
Previously `NoxiousStrike`, but the mod was moved to a different node
and there are also other sources of the mod, that use the same global
limit. So it made sense to change the name of the key now
@majochem
Add support for remaining Assassin mods
56a248f 
- 35% less Damage taken while there are at least two Rare or Unique Enemies nearby
- 100% more Critical Strike Chance against Enemies that are not on Low Life
- +100% to Critical Strike Multiplier against Enemies that are not on Low Life
- Trigger Level 30 Assassin's Mark on Attack Critical Strike against a Rare or Unique Enemy and you have no Mark
- Mark Skills Cost no Mana
- Marked Enemy cannot Evade Attacks
@majochem majochem marked this pull request as ready for review October 24, 2025 10:57
@Wires77 Wires77 added the enhancement New feature, calculation, or mod label Oct 30, 2025
@Wires77 Wires77 merged commit 290ec39 into PathOfBuildingCommunity:dev Oct 30, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wires77 Wires77 Wires77 approved these changes

Assignees

No one assigned

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@majochem @Wires77